search

ezgraphs / ggguitar

Guitar Tablature and
Other
18 stars 1 forks source link

Function Names #3

Open ezgraphs opened 7 years ago

ezgraphs commented 7 years ago

From r-chart.com comments:

"Choice of function names. E.g. the 'tablature' function might be better called 'chord_chart' because it isn't really producing tab - or is that a long-term goal? And 'chord_for_frets' suggests that the function will attempt to look up a chord name (a big ask) whereas it is returning a vector of note names."

ezgraphs commented 7 years ago

Still thinking about this one. Couple of challenges - scales are actually supported too. Will update the vignette in 1.1 to illustrate this use case.