search

ezgraphs / ggguitar

Guitar Tablature and
Other
18 stars 1 forks source link

reverse arguments order in `tablature` function to allow piping #5

Open sam217pa opened 7 years ago

sam217pa commented 7 years ago

I would suggest exchanging the desc and name argument of the tablature function to allow something like: 

c(3, 2, 0, 0, 0, 3) %>% tablature('Gmaj')

instead of doing the less "tidyverse-idiomatic":

c(3, 2, 0, 0, 0, 3) %>% tablature('Gmaj', . )

Thanks for your nice package 😃 !

ezgraphs commented 7 years ago

Yeah - good point. Adding this issue to a milestone where changes to function names / argument lists will be implemented.