search

ezkl / sniffles

Detects popular CMS, Javascript libraries, and other items of interest.
http://documentup.com/ezkl/sniffles
MIT License
35 stars 8 forks source link

Break functionality into sub-libraries #1

Open ezkl opened 12 years ago

ezkl commented 12 years ago

Thinking about breaking each sniffing "pattern" into individual modules; i.e. sniffles-wordpress or sniffles-jquery. The base module would provide the parsers and query methods for common HTML nodes. Thinking mostly about making it easy to extend.

Any feedback on this kind of design @JakeAustwick and @dchuk?

JakeAustwick commented 12 years ago

I like this idea, it makes things much more organised and easier / cleaner to add new modules / patterns. I say go for it.

JakeAustwick commented 12 years ago

I'm not sure on the best way to structure this, I've never really built something using a sub-module typed structure as you suggest, I'm still fairly new to Ruby, so I'll let you handle this. But once this is implemented I'll be more than happy to extend this project with a number of detection methods for common CMS's and scripts, as me and @dchuk have a use for this.

ezkl commented 12 years ago

Before making this sort of structural change, I'd like to focus on adding better sniffer definition to the core library API. I made the first major step with v0.1.0. I've broken sniffers into individual classes under categorized sub-directories in the main repository. Hopefully this will make adding more sniffers easier for everyone while we figure out how to improve the API.

All of that said, sub-libraries are sounding better and better.