ezl / todo

0 stars 0 forks source link

improve mobile/responsive experience #39

Closed ezl closed 2 years ago

ezl commented 2 years ago

Question:

yassinya commented 2 years ago

@ezl Regarding small viewports without touch functionality, what if we add support for long-press (with mouse)?

ezl commented 2 years ago

@yassinya I was thinking about this. I decided that for now, we just won't support anything on narrow viewports without touch functionality.

Basically, if a user has a desktop and they choose to keep the narrow view, then they just don't have access to the multiselect functionality. They can just widen their viewport if they need to do those things.

ezl commented 2 years ago

looks good!

A few comments / questions:

  1. on long press on my phone, i find that it ALSOO triggers the native OS behavior to select the text of the to do list item. this is confusing because it FIRST triggers the text selection, then AFTER that, the slide occurs.

(A) is it possible to restrict the native device behavior? (B) alternatively, what if we make the off screen slide behavior trigger sooner so that it doesn't happen AFTER thae native device highlight behavior

On this item -- please just let me know what you think / if there are other options that you recommend.

  1. the "slide to reveal select buttons" behavior is really good. however, on pressing "cancel", there is no animation. Can you animate this sliding back at the same speed as the slide to reveal please?

  2. when the items shifted and the selection radios are revealed, please make it so that the item that was long pressed is already selected. (basically long pressing an item A. reveals the multiselect, B. selects the item that was long pressed)

yassinya commented 2 years ago

@ezl

  1. Yes, we can temporarily prevent native text selection while sliding. I’ll look into this and take care of it as soon as possible
  2. That is definitely possible, I’ll add another animation for sliding back
  3. Roger that!
ezl commented 2 years ago

perfect. let's do that then.

  1. just prevent the native text selection while sliding.
  2. animate sliding back
  3. autoselect the longpressed item.

:)