ezmsg-org / ezmsg

Pure-Python DAG-based high-performance SHM-backed pub-sub and multi-processing pattern
https://ezmsg.readthedocs.io/en/latest/
MIT License
15 stars 6 forks source link

We should tag the last commit before SETTINGS change from annotate to assignment #138

Closed cboulay closed 3 months ago

cboulay commented 3 months ago

IIUC, #135 breaks a bunch of things.

I need a tag of something recent, but before this breaking change, so I can point my in-development projects to that tag until I can update all the dependencies. As far as I can tell, the last commit before this breaking change is: f166574fb86922e1b9012994277fdaa46780c57a

We should tag it with v3.4.1. Then current dev should have its version in pyproject.toml updated to 3.5.0 and then that commit can be tagged v3.5.0.

It's entirely possible that #135 doesn't actually break old code, I haven't tested, so maybe this isn't necessary.

pperanich commented 3 months ago

135 should not introduce a breaking change, but it will log a warning that using the annotation method will be deprecated at some point in the future. But for now, there is still logic for handling settings and state specified via annotation.

pperanich commented 3 months ago

See: https://github.com/ezmsg-org/ezmsg/blob/48fbe933f3ad0e2adc08a401dba123e4c7eb1bcc/src/ezmsg/core/component.py#L25-L36

cboulay commented 3 months ago

Ah OK. That's great. Then we can reserve tags for releases. Thanks!