sigproc: EWMFilter does not use its SETTINGS.zero_offset

ezmsg-org / ezmsg

Pure-Python DAG-based high-performance SHM-backed pub-sub and multi-processing pattern

https://ezmsg.readthedocs.io/en/latest/

MIT License

9 stars 5 forks source link

sigproc: EWMFilter does not use its SETTINGS.zero_offset #39

Closed cboulay closed 8 months ago

cboulay commented 8 months ago

Hi there, I'm getting familiar with the library, reading code, and came across what might be a bug or maybe my misunderstanding.

zero_offset=True is passed to EWM, when I think it should probably be zero_offset=self.SETTINGS.zero_offset. But I might be misunderstanding something.

https://github.com/iscoe/ezmsg/blob/005590f74ec66b22cd36a94827ff5822ee4bbc92/extensions/ezmsg-sigproc/ezmsg/sigproc/ewmfilter.py#L111

griffinmilsap commented 8 months ago

Good eyes! this actually explains some wonky behavior I was seeing a few months ago. This is absolutely a bug.