Some big improvements - Githubissues

ezod / flipperzero-gps

Flipper Zero application for NMEA 0183 serial GPS modules.

GNU General Public License v3.0

281 stars 26 forks source link

Some big improvements #10

Closed xMasterX closed 1 year ago

xMasterX commented 1 year ago

Modifications made

Ability to change baudrate using Up button, hold button to switch between baudrates (9600, 19200, 38400, 57600, 115200) (i set 57600 as default)
Ok button will set backlight to always on mode, to disable press ok button again (it will restore default settings after app exit too)
Long press Right button to change speed from knots to kilometers per hour
Exit from app using long press on back button instead of short press, may be useful in case you want to turn backlight on and accidentally click back
./fbt format - was applied
Stability fixes

ezod commented 1 year ago

Awesome, thank you!

Any particular reason for 57600 as default baud rate? It looks to me like most modules output at 9600.

I also don't want to apply the ./fbt format to minmea.h or minmea.c as those are third party, can we remove that from the diff? Ideally in general, apply big formatting changes in a separate PR, or at least a separate commit, as it makes it difficult to review the functional changes.

xMasterX commented 1 year ago

Awesome, thank you!

Any particular reason for 57600 as default baud rate? It looks to me like most modules output at 9600.

I also don't want to apply the ./fbt format to minmea.h or minmea.c as those are third party, can we remove that from the diff? Ideally in general, apply big formatting changes in a separate PR, or at least a separate commit, as it makes it difficult to review the functional changes.

I don't have much time to slice that into two PRs You can apply fbt format to your current source then you will see only actual changes without formatter things About default value - i set it to 57k since my module uses that, and it was making testing easier in my case You can change it to value that you think will fit the most

And about minmea.h and minmea.c I can revet format changes from them

ezod commented 1 year ago

This is ready to merge once the changes to minmea.h and minmea.c are reverted. I don't see an easy way to do that from the web UI, but locally you can either make a revert commit, or use amend or rebase better yet.