search

ezolenko / rollup-plugin-typescript2

Rollup plugin for typescript with compiler errors.
MIT License
822 stars 71 forks source link

- partially undoing lodash change #333

Closed ezolenko closed 2 years ago

ezolenko commented 2 years ago

Partially undoing recent lodash change (#328), _.each() semantics is apparently different from Array.forEach() -- during the build it created "undefined" folder with bunch of empty files.

agilgur5 commented 2 years ago

during the build it created "undefined" folder with bunch of empty files.

ah my bad, thanks for catching this and the exact line too.

I did see this folder once or twice but thought that was because of all the other changes and investigations I was doing and just a temporary thing I broke -- turns out it wasn't temporary 😅 It also doesn't pop up during testing because, well, there are no tests for this yet

_.each() semantics is apparently different from Array.forEach()

The semantics are only slightly different in that _.each handles falsey values, while .forEach doesn't -- but .forEach doesn't need to, as you can only use it on arrays anyway.

Another reason why I think it's a problem with this instead

ezolenko commented 2 years ago

Right, I committed that change directly https://github.com/ezolenko/rollup-plugin-typescript2/commit/43108732dfaace0a389550edef75b09996d313b9