refactor: split out a common `typecheckFile` func

agilgur5 commented 2 years ago

Summary

Split out a common typecheckFile function used in 3+ places to DRY up more code

this is used in 3 places and going to be more for the code I'm adding to fix type-only imports in #345 (and probably more type-only PRs in the future)
- so DRY it up and standardize the functionality too
- some places had noErrors = false in one place while others had it in another
- same for printDiagnostics
- but the ordering actually doesn't matter, so just keep it consistent and the same
  - and then can split a common function that does both out
technically, now getDiagnostics (from #328) is now only used in typecheckFile, so I could combine the two together, but I'm refactoring that one up a little
- but this a good, small example of how refactoring one part of a codebase can make it easier to identify more similar pieces and then refactor even more

agilgur5 commented 2 years ago

@ezolenko this one's ready to merge -- not sure if you skipped it intentionally or not

ezolenko commented 2 years ago

@agilgur5 just the comment on line 204

agilgur5 commented 2 years ago

@ezolenko oh, I don't see a comment -- I think maybe you didn't hit "Submit Review"? Code comments are saved as draft by default

ezolenko commented 2 years ago

Ah, no wonder...