Closed agilgur5 closed 2 years ago
@ezolenko this one's ready to merge -- not sure if you skipped it intentionally or not
@agilgur5 just the comment on line 204
@ezolenko oh, I don't see a comment -- I think maybe you didn't hit "Submit Review"? Code comments are saved as draft by default
Ah, no wonder...
Summary
Split out a common
typecheckFile
function used in 3+ places to DRY up more codeDetails
this is used in 3 places and going to be more for the code I'm adding to fix type-only imports in #345 (and probably more type-only PRs in the future)
noErrors = false
in one place while others had it in anotherprintDiagnostics
technically, now
getDiagnostics
(from #328) is now only used intypecheckFile
, so I could combine the two together, but I'm refactoring that one up a little