Formally deprecate rollupCommonJSResolveHack as it's been obsolete since 0.30.0
Details
this has had no effect since #251
that changed the code to always return OS native paths via the NodeJS Path API
so setting rollupCommonJSResolveHack would make no difference either true or false
effectively, it's as if it's always true now
formally state now that this is deprecated in the docs
as well as when that occurred and what it means
also add a warning in options similar to the existing one for objectHashIgnoreUnknownHack (from cd76b42f5509b8ab7b1564373ed2b2ce0d5c7bdd, which was added to my first major contribution back in #203 π )
remove the resolve dependency as well
it turns out something in the devDeps still uses it, so it didn't get fully removed in the package-lock.json
Related: I actually don't think your old comment there is correct; so long as commonjs is internally consistent, it shouldn't matter what kind of paths are passed to it, as it is normalized to the same string either way
and released in 10.1.0, which seems to have been the last version before the move to @rollup/plugin-commonjs
Summary
Formally deprecate
rollupCommonJSResolveHack
as it's been obsolete since 0.30.0Details
this has had no effect since #251
rollupCommonJSResolveHack
would make no difference eithertrue
orfalse
true
nowformally state now that this is deprecated in the docs
also add a warning in
options
similar to the existing one forobjectHashIgnoreUnknownHack
(from cd76b42f5509b8ab7b1564373ed2b2ce0d5c7bdd, which was added to my first major contribution back in #203 π )remove the
resolve
dependency as wellpackage-lock.json
resolve
was never needed anyway as we could've used NodeJS's nativepath.resolve
orrequire.resolve
instead (noted this at the bottom of https://github.com/ezolenko/rollup-plugin-typescript2/issues/234#issuecomment-1139202740)resolve
was created forbrowserify
after all, where one can't use NodeJS APIspath.resolve
andrequire.resolve
References
rollup-plugin-commonjs
: https://github.com/rollup/rollup-plugin-commonjs/issues/177commonjs
is internally consistent, it shouldn't matter what kind of paths are passed to it, as it is normalized to the same string either way10.1.0
, which seems to have been the last version before the move to@rollup/plugin-commonjs