ezolenko / rollup-plugin-typescript2

Rollup plugin for typescript with compiler errors.
MIT License
822 stars 71 forks source link

test: add initial integration test suite #371

Closed agilgur5 closed 2 years ago

agilgur5 commented 2 years ago

Summary

Creates a test harness/structure for integration tests and adds an initial integration test suite to it

Details

EDIT: added more tests below!

Review Notes

Creating the harness itself was probably the biggest "mental" blocker for me (mostly in the number of unknowns to solve, but didn't end up being that complex). Now that this is created, I've already started adding more tests to it, namely for edge cases and error cases. Might add some to this PR pending when it gets merged, but otherwise will add those in additional PRs.

agilgur5 commented 2 years ago

I've added a handful more integration tests now, so this is now a proper integration test suite, and not just a simple one-test harness anymore. Edited the title and description of the PR to match.

Had to bump test timeouts a couple times since integration tests take a good bit longer, especially when comparing two builds against each other (e.g. for cache / no cache).

A few more areas to add tests to:

But this PR is (still) ready to review/merge, those are extras and can be done in future PRs (same as the tests I added today on top of the simple harness from a week ago)

ezolenko commented 2 years ago

Awesome!