fix(diagnostics): workaround Rollup duplicating error messages

[agilgur5]

Summary

Adds a workaround for a Rollup bug that causes duplicate error messages

• Fixes #103
• Goes along with #372, which makes this bug much more noticeable

Details

• per https://github.com/ezolenko/rollup-plugin-typescript2/issues/103#issuecomment-1172820658 and my investigation in #372, it seems like Rollup has a bug where it duplicates some error message

  • this occurs when the error has a stack (or frame) which contains the error message itself
  • Rollup prints both the error message and the stack in that case, causing duplication

• this fix adds a workaround for this upstream Rollup bug

  • it detects if there is a stack and if the message is duplicated in the stack
  • if so, it removes the duplication in the stack
  • this workaround should be forward-compatible if this behavior is fixed upstream
  • this code should just end up re-throwing in that case (effectively a no-op)

Review Notes

This is gonna merge conflict pretty hard with #345 's current code (as these both add the buildEnd hook), but I made them both compatible with each other. Will just have to update one or the other when one is merged

Future Work

I'll make a PR to Rollup proper and link it here as well

[agilgur5]

sh*t, I was reading https://github.com/ezolenko/rollup-plugin-typescript2/issues/103#issuecomment-549948943 and this seems to break watch mode for some reason.... back to the drawing board again....

[agilgur5]

Oh... well apparently Rollup needs some other properties that it attaches to the error:

{
    id: '/project-dir/src/difference.ts',
    hook: 'transform',
    code: 'PLUGIN_ERROR',
    plugin: 'rpt2',
    watchFiles: [
      '/project-dir/src/index.ts',
      '/project-dir/tsconfig.json',
      '/project-dir/src/types.ts',
      '/project-dir/src/difference.ts'
    ]
  }
}

So need to spread those in. And spreading them in makes watch mode work again, thankfully

[agilgur5]

This has been fixed upstream in Rollup in https://github.com/rollup/rollup/pull/4749 and released in Rollup v3.7.5