Closed agilgur5 closed 2 years ago
The integration tests (#371) and pretty default change (#372) got merged simultaneously, so the tests need to be updated to handle the new pretty default
pretty
master
the coloration of the errors is quite different when using pretty
also TS doesn't specify semantic vs. syntax, that's something print-diagnostics does
print-diagnostics
this test is more resilient to change as well I suppose since no error codes or colors
Add unit tests for both pretty and non-pretty versions of errors; currently print-diagnostics is one of the few files without unit test coverage
Summary
The integration tests (#371) and
prettydefault change (#372) got merged simultaneously, so the tests need to be updated to handle the newprettydefaultmasteris currently failing CI due to thisDetails
the coloration of the errors is quite different when using
prettyalso TS doesn't specify semantic vs. syntax, that's something
print-diagnosticsdoesthis test is more resilient to change as well I suppose since no error codes or colors
Future Work
Add unit tests for both
prettyand non-prettyversions of errors; currentlyprint-diagnosticsis one of the few files without unit test coverage