fix: add back `noErrors = false` to `emitSkipped`

ezolenko / rollup-plugin-typescript2

Rollup plugin for typescript with compiler errors.

MIT License

820 stars 71 forks source link

fix: add back `noErrors = false` to `emitSkipped` #381

Closed agilgur5 closed 2 years ago

agilgur5 commented 2 years ago

Summary

Make noErrors = false unconditional again in emitSkipped

Follow-up to https://github.com/ezolenko/rollup-plugin-typescript2/pull/344#discussion_r914336553

Details

apparently emitSkipped can indeed happen without there being a semantic or syntactic error
- so add back the previous unconditional behavior of noErrors
still not clear what exactly triggers emitSkipped though, see my TS issue https://github.com/microsoft/TypeScript/issues/49790

agilgur5 commented 2 years ago

Oh... well I didn't quite realize this (was refactoring/simplifying this code a bit after all), but this is totally redundant because this.error bails out anyway, so the single log statement that noErrors is used for will never be reached anyway 😐