fix: don't duplicate type-only check on Windows - Githubissues

ezolenko / rollup-plugin-typescript2

Rollup plugin for typescript with compiler errors.

MIT License

822 stars 71 forks source link

fix: don't duplicate type-only check on Windows #385

Closed agilgur5 closed 2 years ago

agilgur5 commented 2 years ago

Summary

Ensure that the type-only / "missed" type-check doesn't duplicate on Windows

Fixes https://github.com/ezolenko/rollup-plugin-typescript2/pull/345#issuecomment-1182156954 and the currently failing CI on master

Details

gotta remember to normalize file names 🙃
- this fixes a failing test on Windows by fixing the underlying bug
refactor: improve normalization in errors.spec
- normalize all calls to local, instead of just one
- this doesn't affect the tests, only the source code change does, but I added this first and it's better practice / test future-proofing

Review Notes

I confirmed on CI on my fork that tests pass on Windows now

EDIT: and as double check, they pass here on this PR too