optim(cache): don't check imports for syntactic diagnostics - Githubissues

ezolenko / rollup-plugin-typescript2

Rollup plugin for typescript with compiler errors.

MIT License

820 stars 71 forks source link

optim(cache): don't check imports for syntactic diagnostics #389

Closed agilgur5 closed 2 years ago

agilgur5 commented 2 years ago

Summary

Syntactic diagnostics are only per-file, so we don't need to checkImports in the cache's isDirty check for them

Details

Per the TS LS Wiki, syntactic diagnostics only need to parse the specific file in question
- since syntax is independent of imports; imports only affect semantics

References

Just happened to finally realize this while reading the LS Wiki for #388 .
Related to #369 ; that was a de-opt for codeCache, this is an optimization for syntacticDiagnosticsCache