ezolenko / rollup-plugin-typescript2

Rollup plugin for typescript with compiler errors.
MIT License
822 stars 71 forks source link

refactor: combine two context files into one #396

Closed agilgur5 closed 2 years ago

agilgur5 commented 2 years ago

Summary

Merge the two context files into a single file as they're intended to be as similar as possible. They're also not meant to be more extensible to create other contexts (unlike say, the cache interfaces etc), these are the only two contexts intended.

IMO, the slight, small distinction between them would've been easier to understand/catch on to if I saw them together like this than in separate files.

Details

Future Work

agilgur5 commented 2 years ago

Very likely that ConsoleContext will be removed per my realization in https://github.com/ezolenko/rollup-plugin-typescript2/pull/345#issuecomment-1200277838, but this PR will also make it easier to remove it as all the code is now in this one file and all the imports are from this one file