Closed agilgur5 closed 1 year ago
Early return after filter in the resolveId hook, same as we do in transform
filter
resolveId
transform
if they're excluded / not included, then we shouldn't be processing them
exclude
include
allImportedFiles
Set
tsconfig
also move .d.ts check to above the filter check
.d.ts
cache
types: be more specific with filter's type
any
I also did a build and version bump in this PR as folks have been waiting for a patch for a few weeks, c.f. https://github.com/ezolenko/rollup-plugin-typescript2/pull/422#issuecomment-1257076913 (I also recommended a patch in that PR's opening comment)
build
@agilgur5 released in 0.34.1, thanks
0.34.1
updated the release notes 👍
Summary
Early return after
filter
in theresolveId
hook, same as we do intransform
Details
if they're
exclude
d / notinclude
d, then we shouldn't be processing themallImportedFiles
Set
that previously filtered out files not in thetsconfig
include
filter
should have never been resolvedallImportedFiles
regression was covering up this long-standing bugalso move
.d.ts
check to above thefilter
checkcache
, in particular as we don't process declarations, so they'll never be marked as dirtyfilter
should be slightly more efficient as well (as would not having these files in the cache graph)types: be more specific with
filter
's typeany
Review Notes
I also did a
build
and version bump in this PR as folks have been waiting for a patch for a few weeks, c.f. https://github.com/ezolenko/rollup-plugin-typescript2/pull/422#issuecomment-1257076913 (I also recommended a patch in that PR's opening comment)