search

ezpaarse-project / ezpaarse-middlewares

Middlewares for ezPAARSE
0 stars 8 forks source link

Robots #54

Closed paulgirard closed 2 weeks ago

paulgirard commented 2 weeks ago

Robots uses mongodb.collection methods. The mongodb lib is set to 6.8.0 in package.json. This version uses Promises were the tobots middleware code uses callbacks. Robots was not working and not ending jobs as the callbacks were ignored by mongodb lib. I converted callback to promise.then and promise.catch.

nojhamster commented 2 weeks ago

Hi there ! This pull request includes code that is out of its scope (added by mistake ?). However, I retrieved the robots fix and commited it with some refactoring (cf 7532559c3647f507aa91eb88aaccf78ce5f862c5). I invite you to open another PR for the OpenAlex middleware, if you actually intended to submit it. Thanks !

paulgirard commented 2 weeks ago

Oh yeah the open alex was not supposed to be included here. It's not ready to be shared but it will be once tested.