search

ezpaarse-project / ezpaarse

ezPAARSE can ingest your (proxy) log files and show how users access suscribed electronic ressources.
http://www.ezpaarse.org
Other
70 stars 27 forks source link

Introduce ESlint #23

Closed nojhamster closed 8 years ago

nojhamster commented 8 years ago

Changes :

kerphi commented 8 years ago

"Drop ezpaarse-libs (which is a pain to keep in sync) in favor of plain npm/bower install" ===> how will it impacts the ezpaarse installation all around the world ?

nojhamster commented 8 years ago

The change won't have any effect on older versions of ezPAARSE. For recent installations, this will have the following benefits :

The potential drawback : No more fixed version for npm modules. Dependencies in the package.json should use ~ instead of ^ (or even exact versions). If the need for fixed versions shows up again, shrinkwrap should do a better job and should be easier to maintain.

NB: this new behaviour is still revertable if anyone thinks of a critical issue.

kerphi commented 8 years ago

go ahead the agile way ! :)

On Fri, Feb 19, 2016 at 1:33 PM, Yannick Schurter notifications@github.com wrote:

The change won't have any effect on older versions of ezPAARSE. For recent installations, this will have the following benefits :

  • No synchronization problems (ie. ezpaarse@stable but libs@master)
  • No need to reduild the lib repository when changing node version
  • Faster installation of libs (geoip doesn't need an absurd 10min build anymore)
  • Faster ezpaarse build, especially if libs are already installed

The potential drawback : No more fixed version for npm modules. Dependencies in the package.json should use ~ instead of ^. If the need for fixed versions shows up again, shrinkwrap should do a better job and should be easier to maintain.

NB: this new behaviour is still revertable if anyone thinks of a critical issue.

— Reply to this email directly or view it on GitHub https://github.com/ezpaarse-project/ezpaarse/pull/23#issuecomment-186198864 .