Adaptation to upcoming changes in aiida transport plugins

ezpzbz / aiida-metavo-scheduler

Custom AiiDA scheduler plugin for MetaCentrum HPC

MIT License

0 stars 0 forks source link

Adaptation to upcoming changes in aiida transport plugins #2

Open ezpzbz opened 3 years ago

ezpzbz commented 3 years ago

Currently, there is an open PR on aiida-core which is touching transport plugins. This plugin needs some modifications which are suggested by @giovannipizzi in here. For now, I'm putting a limit on aiida-core version in this plugin until I apply the changes.

giovannipizzi commented 3 years ago

The PR has been merged. Note that the limit should be <2.0 now and now <1.6 (1.6 still has the "old" code and does not include the PR)

ltalirz commented 2 years ago

@pzarabadip By the way, I notice that your transport plugin inherits from Transport. Is that on purpose or would it perhaps make sense to inherit from SshTransport instead and just modify the parts that need to be modified?

That could reduce the maintenance burden on your side (possibly the same for the scheduler plugin).

As transports are now being developed that are significantly different from SSH, we may see some changes to the transport API.