search

ezrosent / allocators-rs

Allocators in Rust
Apache License 2.0
311 stars 28 forks source link

bsalloc: improve cache #171

Closed teg closed 4 years ago

teg commented 6 years ago

I noticed some minor things as I'm looking through the code.

joshlf commented 6 years ago

Hi @teg, thanks for the PR!

@ezrosent and I are pretty busy right now, so we probably won't be able to get to this for a bit, but we really appreciate the PR! In the meantime, if you're interested in contributing beyond this PR, feel free to check out the issues and let me know if you have any questions about anything.

teg commented 6 years ago

Thanks @joshlf! Do you have a preferred communication channel for general questions? For now I thought I'd just file some PRs for stuff I notice as I try to wrap my head around the code, but take your time reviewing it.

joshlf commented 6 years ago

Comments on issues/PRs are fine, and email works fine too (hello@joshlf.com) for longer-form or more open discussion.

joshlf commented 6 years ago

Hey, sorry for the delay. The code looks good! If you wouldn't mind squashing the last two commits (the ones about the rng) into one, we'll merge!

teg commented 4 years ago

I won't be working on this.