search

ezrosent / frawk

an efficient awk-like language
Apache License 2.0
1.24k stars 34 forks source link

fast-float can be removed when using #72

Closed ghuls closed 2 years ago

ghuls commented 2 years ago

fast-float can be removed when using a recent rust compiler. Similar algoritm now in standard library: https://www.reddit.com/r/rust/comments/omelz4/making_rust_float_parsing_fast_libcore_edition/ https://github.com/pola-rs/polars/issues/1010

ezrosent commented 2 years ago

Thanks for the pointer! I'll double check and re-run some benchmarks but assuming all goes well I will remove the fast-float dependency and just use the standard library.

ezrosent commented 2 years ago

Hmm, we need partial parsing. I'm not sure if the standard library has this for f64. I'll look around some more.

ezrosent commented 2 years ago

Unfortunately I don't think I can remove the fast-float dependency because awk's string conversions work with any prefix to a string (parse_partial in fast-float). Thanks for the pointer though, this was good to read up on.