search

ezrosent / frawk

an efficient awk-like language
Apache License 2.0
1.24k stars 34 forks source link

docs: add mac os specific instructions #78

Closed barakplasma closed 2 years ago

barakplasma commented 2 years ago

also needed to add #![feature(extended_key_value_attributes)] to .cargo/registry/src/github.com-1ecc6299db9ec823/clap-3.0.0-beta.4/src/lib.rs to get around a build failure on Mac OS

   Compiling clap v3.0.0-beta.4
error[E0658]: arbitrary expressions in key-value attributes are unstable
 --> /Users/smichael1/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-3.0.0-beta.4/src/lib.rs:8:10
  |
8 | #![doc = include_str!("../README.md")]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #78835 <https://github.com/rust-lang/rust/issues/78835> for more information
  = help: add `#![feature(extended_key_value_attributes)]` to the crate attributes to enable

built via cargo +nightly install --path .

Thanks again for this project @ezrosent !

ezrosent commented 2 years ago

Thanks for the PR!

For this clap issue, reading through this similar issue makes me think it could be solved by doing rustup self update && rustup update and then attempting a reinstall. In general, modifying local copies of dependencies can be tricky as they changes can be blown away by rebuilds. Feel free to let me know if you continue to have trouble getting frawk running on your machine.

barakplasma commented 2 years ago

Thanks for the suggestion to run rustup self update @ezrosent! I went from 1.51.0 to 1.55.0 and now I don't get that clap error anymore.

stable-x86_64-apple-darwin updated - rustc 1.55.0 (c8dfcfe04 2021-09-06) (from rustc 1.51.0 (2fd73fabe 2021-03-23)) nightly-x86_64-apple-darwin updated - rustc 1.58.0-nightly (1f12ac872 2021-10-17) (from rustc 1.53.0-nightly (42816d61e 2021-04-24))

Though I did notice on running cargo +nightly install today that it also downloaded clap v3.0.0-beta.5 instead of beta.4 , so that might also have removed the issue. In any case, it's no longer happening for me. Also, all the cargo tests are passing now.

What would you say about updating the edition to 2021? So that the requirement for nightly is more obvious for others? Like this:

Rust includes tooling to automatically transition a project from one edition to the next...If you are migrating from 2018 to 2021, the steps are slightly different because 2021 is not yet stabilized, and is only available on the nightly channel. The steps to follow are:

Install the most recent nightly: rustup update nightly. Run cargo +nightly fix --edition. Edit Cargo.toml and place cargo-features = ["edition2021"] at the top (above [package]), and change the edition field to say edition = "2021". Run cargo +nightly check to verify it now works in the new edition.

(copied from here)

I can open a new PR for this