Naming Convention and Code Structure

[ghost]

We're really getting ahead with the project and I feel like it is necessarily to set some sort of standards on our code.

I suggest PSR-1 and PSR-2. It has clear instructions on how the code should be structured as well for the naming convention.

I'd also would want a look at some of our current variables, i.e. site URL i'd rather see it as some base_url, in my opinion caps should only be in CONSTANTS.

So my final suggestion is:

• Review the current variables names
• Use PSR-1 and PSR-2.

[ferdis]

-1 I've already expressed my feelings about PSR-2 before. I'm all on with PSR-0 though.

On 2013/05/25 04:37 PM, alex857 wrote:

We're really getting ahead with the project and I feel like it is necessarily to set some sort of standards on our code.

I suggest PSR-1 and PSR-2. It has clear instructions on how the code should be structured as well for the naming convention.

I'd also would want a look at some of our current variables, i.e. site URL i'd rather see it as some base_url, in my opinion caps should only be in CONSTANTS.

— Reply to this email directly or view it on GitHub https://github.com/uaktags/Rework-Revisited/issues/9.

[ghost]

What about the variable names?

[uaktags]

I can dig the uppercase for variables.

[ferdis]

What about using K&R style? I wouldn't mind switching to it, although block structures are different from my preferred programming style. We can mix it quite easily with OTBS, but the differences are so minimal that it wouldn't matter.

I see uaktags and alex857 both are already using variants of it.