search

ezsystems / eztags

GNU General Public License v2.0
40 stars 40 forks source link

Added $keyword variable to fetches in eztags #55

Closed tbuljevic closed 8 years ago

tbuljevic commented 12 years ago

This pull request is for the changes of the fetch functions in eztags which makes it possible for a user to fetch a tree or a list of tags and their respective counts using the $keyword variable which filters the results by the keyword required. The $keyword variable is not a required variable making it possible for the fetch functions to retain their previous functionality.

emodric commented 12 years ago

Hi, this is good, but incomplete. While you did transfer $params['Keyword'] to eZTagsObject::subTreeByTagID and eZTagsObject::subTreeCountByTagID, those methods are still unaware of it and do nothing with it.

Also, it would be great if keyword matching would support wildcards, just as fetch_by_keyword does (see eZTagsObject::fetchByKeyword for example how to do that)