Renamed admin2 to admin, since admin2 is gone since early 2013.

[e42sh]

Since admin2 was merged into admin, the extension is not compatible anymore with ezpublish legacy. I had to rename admin2 into admin to make it work again.

http://doc.ez.no/eZ-Publish/Upgrading/Upgrading-to-5.0/Upgrading-from-4.7-to-5.0

[lolautruche]

Hi This is not necessary since admin design silently fallbacks to admin2 in default configuration...

[emodric]

Hi @meckhardt, @lolautruche is right. Fallback is there precisely for these cases.

[e42sh]

Thanks, so I close this.

[emodric]

@meckhardt I'm curious...

You wrote:

the extension is not compatible anymore with ezpublish legacy. I had to rename admin2 into admin to make it work again.

What exactly was not working?

[e42sh]

I downloaded ez5 and extracted the legacy part. But there was no admin2 configured in site.ini anymore. So design was not loaded correctly for eztags.

2013/6/28 Edi Modrić notifications@github.com

@meckhardt https://github.com/meckhardt I'm curious...

You wrote:

the extension is not compatible anymore with ezpublish legacy. I had to rename admin2 into admin to make it work again.

What exactly was not working?

— Reply to this email directly or view it on GitHubhttps://github.com/ezsystems/eztags/pull/61#issuecomment-20176187 .

[emodric]

This sounds like an issue with setup wizard of eZ Publish. This should not happen. Ping @lolautruche

[lolautruche]

Might be an issue indeed (cc @bdunogier). @meckhardt Can you please open an issue on https://jira.ez.no ?

Thanks :smiley:

[andrerom]

I think this was the intended way, new installs don't enable admin2 anymore as it's gone, old sites can keep it activated for bc.

[emodric]

@andrerom That doesn't sound right. Why disable admin2 when it doesn't affect anything, it only confuses people?

Also, there are many extensions out there that cannot change admin2 design to admin for backwards compatibility with older versions of eZ Publish.

[lolautruche]

I agree with @emodric here

[andrerom]

sure, but be aware that this has been broken since 5.0.. So it's maybe a bit late to change/fix this. So given that context I would say either:

• rename/merge admin2 to admin for 5.0 and higher in 5.0 extensions.
• document in this extension that admin2 must be enabled and do PR to legacy to make sure admin2 is enabled on new installs for the future

[emodric]

I would disagree. It's never too late to fix it. 2013.07. is just around the corner.

I think lots of extensions that have some kind of admin design can work both on 4.x & 5.x LS without any changes. If you use admin design, they will break on 4.x, if you use admin2 they will break on 5.x LS, when they could work without any problems in both versions if admin2 is used in 5.x INI files. It's kinda pointless to have two versions of an extension (one for 4.x and one for 5.x LS) purely because the name of the admin design is changed.

[andrerom]

@emodric Fixing it the way you want is option 2, it means there should be documentation in this and other extensions to make sure admin2 design is enabled, + fix in legacy.

[emodric]

@andrerom I would go for that, that sounds OK.

@lolautruche @bdunogier Your opinions?

[e42sh]

@lolautruche do you still need a ticket?

[lolautruche]

I follow @andrerom on this.

[bdunogier]

So, what's the consensus ? Any action ?

[andrerom]

@bdunogier We need a issue (if not already exists) to fix legacy to keep admin2 enabled on clean installs for bc. And @emodric or someone else should optimally add a mention in the install doc about this for 5.0/5.1 (same goes for other extensions that still rely on admin2 being there).

[emodric]

@andrerom Install docs added -> https://github.com/ezsystems/eztags/pull/62

[jeromegamez]

After having tried out myself on a current project if renaming eztags/design/admin2 to eztags/design/admin works (it did in my case), I am with @emodric and @andrerom here, which is:

• rename the folder (#61 or #64, which is exactly the same as this PR, I didn't look if someone did it already :/)
• add the information to the INSTALL doc (#62)

:+1:

[andrerom]

@jeromegamez Don't think you read the whole thread. The only option for being able for extensions to support older versions of eZ Publish as well as 5.x is to re add admin2 setting in 5.2+ and document this in upgrade guides + install guides for extensions on 5.0 and 5.1. This is why #61 is closed, and #64 will be as well as long as eztags aims to support older versions.

So the reason why I added +1 on your other PR's is that those extensions are controlled by eZ, and we don't support older eZ Publish versions with newer versions of the extensions (unfortunately, would have saved us a ton of support matrixes, but we can change that when we have all dependencies running over composer instead).

[jeromegamez]

Understood, thank you for the explanation!