ezsystems / eztags

GNU General Public License v2.0
40 stars 40 forks source link

Pagination for 'Latest content' section in admin interface #79

Closed benkmugo closed 9 years ago

benkmugo commented 9 years ago

For sites with large amounts of content & tags showing the 'Latest 10' content objects often isn't sufficient.

The 'Latest content' section template has been extended, adding pagination to allow users to review a larger amount of 'new' content items in that section of the admin UI.

emodric commented 9 years ago

Hi!

That section was never meant to display all content. Its purpose was only meant as a preview of latest objects. I'd rather that you implemented a separate page with listing of related objects, something like /tags/view page on the frontend.

Nevertheless, I didn't test, but it looks to me like this would clash with paging in tags children list.

peterkeung commented 9 years ago

Confirmed: The pagination does clash.

That section might not have been meant to display all content, but I think it's a step backwards to make it another page load. Feedback from clients was that "latest content" by itself rarely satisfies their need. It's more useful to have it on one page -- maybe we should think about mimicking the tabs when viewing content if the current view is getting cluttered.

emodric commented 9 years ago

Tabs are already mimicked in eZ Tags multilanguage branch and it required substantial changes, so I would like to avoid that. But even if we do mimick them, how would you page content in tabs? It would also clash with children list pagination.

Now when I think of it, what's stopping your clients from using /tags/view pages in admin interface? The link is not accessible, but that can be changed, we can put it at the bottom of this list with 10 items. True, it's another page load, but I don't see it as a step backwards, since you do need the page loads to do the actual navigation :)

benkmugo commented 9 years ago

Cheers for the feedback Edi. I'll close this pull request for now.

peterkeung commented 9 years ago

About tags/view, is that a deprecated or hidden debug view? I was just trying to test it out and it doesn't appear to accept any of the parameters I give it. (Just a question for when we eventually circle back around to this.)

emodric commented 9 years ago

It's not a hidden view, it's a view used by the frontend and it uses tags keywords instead of id.

So for example if you have structure like 'Tag 1' -> 'Tag 2' -> 'Tag 3', the link would be /tags/view/Tag+1/Tag+2/Tag+3

ilukac commented 9 years ago

Btw, the biggest tags/view's problem was that it had no view cache. You should at least have varnish in front. With ez5 we could introduce a x-tag-id header and build smarter invalidation, but that is just an idea :)

peterkeung commented 9 years ago

Ah, of course, sorry. I should have known that. Our designs on sites with eZ Tags so far either haven't called for a tags view on the front-end, or 1/4 times we built a custom one! Thanks for the clarification :)

emodric commented 9 years ago

Btw, the biggest tags/view's problem was that it had no view cache. You should at least have varnish in front.

Yep, but if they're gonna use it in admin interface, it doesn't really matter.

With ez5 we could introduce a x-tag-id header and build smarter invalidation, but that is just an idea :)

Been there, done that :) https://github.com/netgen/TagsBundle/commit/4a056b47bbb5766804d1fe29dc90782d4ac5a3e5

ilukac commented 9 years ago

Setting the header is simple. Doing smart invalidation using the header is a bit more complex :)

emodric commented 9 years ago

I know, I have it on my todo list :)