EZP-28820: [Solr] Does not index on publish (and crash on search)

ezsystems / launchpad

CLI tool to bootstrap an eZ Platform project Docker stack | #justcode

https://ezsystems.github.io/launchpad

MIT License

22 stars 27 forks source link

EZP-28820: [Solr] Does not index on publish (and crash on search) #20

Closed kmadejski closed 6 years ago

kmadejski commented 6 years ago

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Fixed tickets	https://jira.ez.no/browse/EZP-28820

This PR solves an issue related to the Solr which doesn't index content on publish and crashes on search. There was default autoSoftCommit value (-1), this PR changes it to 20 as recommended in the documentation.

kmadejski commented 6 years ago

ping @andrerom, @Plopix (I can't ask for review directly)

Plopix commented 6 years ago

awesome guys, I wonder why this line is not directly in the documentation?

Because when you read the following you don't image it will break anything. It says leaving it up to you to tune this using solrconfig.xml as best practice suggests I think that is required!

But anyway thank you!

SylvainGuittard commented 6 years ago

Very good job @kmadejski ! Thanks.

andrerom commented 6 years ago

I think that is required!

It is indeed required, @kmadejski up for improving doc on this? 1.7+

kmadejski commented 6 years ago

@andrerom yes, I'm completely in favor of this change. See referenced PR.