ezsystems / launchpad

CLI tool to bootstrap an eZ Platform project Docker stack | #justcode
https://ezsystems.github.io/launchpad
MIT License
22 stars 27 forks source link

WIP #39 - xdebug support #43

Closed yhanini closed 6 years ago

yhanini commented 6 years ago
Q A
New feature? yes
Plopix commented 6 years ago

Hello @yhanini I am going to refuse that PR and close but it helps a lot!

Actually, we don't need a script to automate the install + the config and also the script limits us in the config we could want for X-DEBUG.

Then I have added X-Debug to the Engine: https://github.com/Plopix/docker-php-ez-engine/commit/db6e6a584da2707dea2cb06a7cc9c37ff8312d7b

And added the default configuration here: https://github.com/ezsystems/launchpad/pull/44/commits/857d991f1881b3bbe4a1163d367e858240eb57da

It is totally configurable easily now, just in the php.ini of the engine. no script, no limitation etc.

https://github.com/ezsystems/launchpad/pull/44/commits/857d991f1881b3bbe4a1163d367e858240eb57da