search

ezsystems / launchpad

CLI tool to bootstrap an eZ Platform project Docker stack | #justcode
https://ezsystems.github.io/launchpad
MIT License
22 stars 27 forks source link

solr service fix, when sudo is used to run init #5

Closed SerheyDolgushev closed 7 years ago

SerheyDolgushev commented 7 years ago

(cherry picked from commit a4083048d0112e8525908b23a910b7763619a5fa)

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Fixed tickets conversation on slack -->

There will be permissions issue without this fix, when init is done using sudo

Plopix commented 7 years ago

Hello! Thank you! Before to merge I am just wondering why would you use sudo? You can run docker without sudo, can't you? I am fine with the fix, but I don't really like 777, will it work with 755? What is the real situation? which user does not have the right?

SerheyDolgushev commented 7 years ago

Sorry, i was using an instance with already installed docker, and i had no permissions to run it without sudo. This issue was fixed after i added my user to docker group and logged again in terminal. In this case there is no need in this change, but probably it worth to mention in docs that there might be some permission issues if sudo is used for ~/ez init?

Plopix commented 7 years ago

yes definitely, we also need to add more check before to run the init.