search

ezsystems / launchpad

CLI tool to bootstrap an eZ Platform project Docker stack | #justcode
https://ezsystems.github.io/launchpad
MIT License
22 stars 27 forks source link

Support non-tty systems (CI) #52

Closed hranicka closed 5 years ago

hranicka commented 5 years ago
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Fixed tickets -

I want to build an application in CI (Gitlab) with eZ Launchpad.

When I executed ~/ez docker:create, the script has failed:

$ ~/ez docker:create --no-interaction

In Process.php line 1042:

  TTY mode requires /dev/tty to be read/writable.

CI does not support TTY but it's required in the code except Windows platform. I've enhanced the condition to check not only the platform, but actual support of TTY.

Also this information is now propagated to Docker client which runs docker-compose exec -T on platform which does not support TTY. Without -T option, docker-compose exec allocated TTY by default and it would not work.

Plopix commented 5 years ago

nice @hranicka ! I think I will merge. Unless you are telling me you are going to add the test soon. but that is a really nice improvement!

hranicka commented 5 years ago

Hello @Plopix , sorry for delay. Now I've added tests :)

Plopix commented 5 years ago

Awesome @hranicka Thanks a lot! ;-)