ezsystems / launchpad

CLI tool to bootstrap an eZ Platform project Docker stack | #justcode
https://ezsystems.github.io/launchpad
MIT License
22 stars 26 forks source link

[Request For Review] Symfony 4, PHP 7.x, Github Actions #72

Closed Plopix closed 4 years ago

Plopix commented 4 years ago

This PR revamps eZ Launchpad on Symfony 4.4 (soon released) and to PHP 7.2 minimum as support for other versions is gone.

It also greatly improves the release mechanism using now Github Actions and Github Release.

Github Actions are not available yet on eZ Systems repository but you can see the result there:

Todos:

So now we are just waiting for Symfony 4.4 and double-check everything. But that could definitely be merged before.

Also Github Conference is in 2 days, and Github Actions should be available for eZ Systems Org as well (I hope..)

What do you think?

Plopix commented 4 years ago

ping @crevillo @nicolasaguenot and @amirkoklan as I think you are using it a lot ;-)

amirkoklan commented 4 years ago

ping @crevillo @nicolasaguenot and @amirkoklan as I think you are using it a lot ;-)

I'm back and give this a try tomorrow as the first thing

andrerom commented 4 years ago

code wise looks about ok, on requirements side not supporting 7.1 means it's not in sync with neither 2.5 or 3.x requirements, but it's up to you.

Plopix commented 4 years ago

hey @andrerom thanks for the feedback. Actually the limitation is not for eZ but for Launchpad which is the CLI that runs on the host. PHP version for eZ Platform is managed in the Docker Container engine as usual.