search

ezyang / htmlpurifier

Standards compliant HTML filter written in PHP
http://htmlpurifier.org
GNU Lesser General Public License v2.1
3.07k stars 327 forks source link

preFilter method (& others) non required parameters #182

Closed samus-aran closed 5 years ago

samus-aran commented 6 years ago

Identifying non required parameters within core project which are then enforced into an extended class unnecessarily. Potentially these could be deem as null to ensure that PHP7 errors don't get flagged up when they are not required to do so when the parameters are more often or not necessary.

https://github.com/ezyang/htmlpurifier/blob/master/library/HTMLPurifier/Filter.php#L38 https://github.com/ezyang/htmlpurifier/blob/master/library/HTMLPurifier/Filter.php#L50

This is a placeholder (and reminder to our devs) to associate a PR with it and reference to the issue raised. https://github.com/salesagility/SuiteCRM/pull/5959

xemlock commented 6 years ago

@samus-aran All of these parameters are necessary, because of how preFilter logic is executed. $config and $context parameters are always provided.

It's up to subclass implementation of preFilter to decide whether to use these parameters or not. I see no reason for any PHP7 errors to appear here.

IMHO this issue is invalid.