search

ezyang / htmlpurifier

Standards compliant HTML filter written in PHP
http://htmlpurifier.org
GNU Lesser General Public License v2.1
3.07k stars 327 forks source link

Adds PHP 7.3 to Travis #214

Closed lksnmnn closed 5 years ago

lksnmnn commented 5 years ago

I am currently reviewing our dependencies for PHP 7.3 compatibility. This should run the the tests on 7.3 :)

lksnmnn commented 5 years ago

I may be able to spend some time on investigating why the tests fail on PHP 7.3.2 on Travis.

Apparently, this happened: Before PHP 7.3, any strings that are not set will silently be skipped. Source: https://www.php.net/manual/en/function.compact.php

ThHareau commented 5 years ago

Hello, I just run into the same issue, I fixed it here https://github.com/ProtonMail/htmlpurifier/commit/0d22798921503e082d6dca70471d94ea9a5a955a

In library/HTMLPurifier/Language/messages/en-x-test.php and library/HTMLPurifier/Language/messages/en-x-testmini.php, you should add a new variable $errorNames = array();.

You may also want to change the version of simpletest from 1.1 to dev-master#72de02a7b80c6bb8864ef9bf66d41d2f58f826bd. In 1.1, the mocking is done using old style constructors, which throws a notice in at least php 7.3.4.

lksnmnn commented 5 years ago

I added the fixes you've done on your fork :) Thanks!

Edit: @ezyang Can we depend on your commit here? I do not think that SimpleTest will release a new version anytime soon.

ezyang commented 5 years ago

Yeah, let's just rely on the SimpleTest fork.