Replace curly braces with square brackets in string offsets

ezyang / htmlpurifier

Standards compliant HTML filter written in PHP

http://htmlpurifier.org

GNU Lesser General Public License v2.1

3.07k stars 327 forks source link

Replace curly braces with square brackets in string offsets #224

Closed emodric closed 5 years ago

emodric commented 5 years ago

Fixes #223

emodric commented 5 years ago

Hi! Thanks for the merge! When do you think you could release a patch version with this fix?

ezyang commented 5 years ago

Probably not in the near future, unless you convince me it is very urgent.

emodric commented 5 years ago

It's not urgent, no, until PHP 7.4 is stable. It would be nice to have our builds green, but I'm not gonna nitpick :)

binarious commented 5 years ago

unless you convince me it is very urgent

We need to check whether our applications are php 7.4 compatible as early as possible. Htmlpurifier makes it hard for us, because of the deprecations.

ezyang commented 5 years ago

You should try testing off of master. It will probably not change much between now and next release

fisharebest commented 5 years ago

7.4-rc1 has been released.

It is now time to tag a new version?

connorshea commented 4 years ago

PHP 7.4.0-rc4 is coming out tomorrow. A new release of HTMLPurifier would be greatly appreciated :)

emodric commented 4 years ago

@ezyang PHP 7.4 is nearing a final release. Can you at least release a patch release to 4.11 ?

Thanks!

binarious commented 4 years ago

v4.12.0 has been released which includes this fix.

connorshea commented 4 years ago

Thanks!