search

ezyang / htmlpurifier

Standards compliant HTML filter written in PHP
http://htmlpurifier.org
GNU Lesser General Public License v2.1
3.07k stars 327 forks source link

Add support for PHP 7.4 #230

Closed snapshotpl closed 5 years ago

snapshotpl commented 5 years ago

Strange: all tests pass, but in my project I get error. Missing test case?

Array and string offset access syntax with curly braces is deprecated

/var/www/vendor/ezyang/htmlpurifier/library/HTMLPurifier/Encoder.php:162
/var/www/vendor/ezyang/htmlpurifier/library/HTMLPurifier.php:177
...
snapshotpl commented 5 years ago

I see it's fixed in master. Great. Anyway, test for 7.4 are ok :-)

snapshotpl commented 5 years ago

@ezyang is it possible to release this changes?

emodric commented 5 years ago

@ezyang Hi. I'd also like to see a new release with PHP 7.4 support.

PHP 7.4 is in RC phase and we would like for our builds to be green.

ezyang commented 5 years ago

okey maybe this weekend

emodric commented 5 years ago

Hi @ezyang. Any news on the release?

sebastiaanluca commented 4 years ago

PHP 7.4 has been released, any news on releasing support for it? Currently can't upgrade our app. Thanks!

ezyang commented 4 years ago

Yes, 4.12.0 is released and has the compat changes.