search

ezyang / htmlpurifier

Standards compliant HTML filter written in PHP
http://htmlpurifier.org
GNU Lesser General Public License v2.1
3.07k stars 327 forks source link

Ambiguous class HTML5 resolution #241

Open bentinata opened 4 years ago

bentinata commented 4 years ago

I'm currently trying to incorporate rector into my projects, and it complains about:

Ambiguous class HTML5 resolution; defined in ./vendor/ezyang/htmlpurifier/maintenance/PH5P.php and in ./vendor/ezyang/htmlpurifier/library/HTMLPurifier/Lexer/PH5P.php.

Here's the offending code: https://github.com/ezyang/htmlpurifier/blob/fe0452d6887a0fa76e2eaf80166e1ea205e7bb81/library/HTMLPurifier/Lexer/PH5P.php#L70 https://github.com/ezyang/htmlpurifier/blob/fe0452d6887a0fa76e2eaf80166e1ea205e7bb81/maintenance/PH5P.php#L2

Would it be technically fine if I rename one of the class? I think the lexer one would be fine since it's a subclass.

Thanks.

ezyang commented 4 years ago

Yeah, feel free to submit a PR renaming, I'll merge it.