PHP 8.1: fix various deprecations/errors in newest version of PHP

[davidrans]

Most of these were caught by the tests. The last commit fixed an issue the tests didn't catch that just came up using the library.

[davidrans]

Done!

[bytestream]

Closes #311

[davidrans]

Anything I can do to help this get merged?

[davidrans]

Let me know if you need anything else from me

[bytestream]

Just a case of waiting :p - I don't think Edward will ask for any other changes.

[ezyang]

What's with all the (string) casts?

[davidrans]

It's been a few weeks, but I think the issue was that pre-8.1 these functions did implicit string casts, and now they require a value of type string to be passed.

[mhujer]

See https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg and https://3v4l.org/NAfiI

[AgentSmith0]

Any updates to this?

[jstanden]

Thanks for the great library. 👍

There's another PHP 8.x warning at: https://github.com/ezyang/htmlpurifier/blob/master/library/HTMLPurifier/AttrTransform/TargetBlank.php#L38

Attempt to read property "browsable" on bool

[pyres01]

邮件已收到，谢谢！

[henriquegomes6]

any news?

[marcovtwout]

There's another PHP 8.x warning at: https://github.com/ezyang/htmlpurifier/blob/master/library/HTMLPurifier/AttrTransform/TargetBlank.php#L38

url->getSchemeObj() could return false, so this can be fixed with:

-    if ($scheme->browsable && !$url->isBenign($config, $context)) {
+    if ($scheme !== false && $scheme->browsable && !$url->isBenign($config, $context)) {

[marcovtwout]

Tested this branch through a standalone build on a few project configurations - have not seen any new errors yet. :) Looking forward to this being merged and 4.15.0 released.

[AgentSmith0]

Thanks!

[davidrans]

Thank you!

[pyres01]

邮件已收到，谢谢！