ezyang / htmlpurifier

Standards compliant HTML filter written in PHP
http://htmlpurifier.org
GNU Lesser General Public License v2.1
3.03k stars 323 forks source link

Fix PHP 8.2 deprecated utf8_encode, decode (ezyang#320) #321

Closed kitrio closed 2 years ago

kitrio commented 2 years ago
PHPGangsta commented 2 years ago

Quick note: utf8_encode() always returned a string in the past. self::iconv() might return false, which you don't check. This might lead to a bug?

kitrio commented 2 years ago

Quick note: utf8_encode() always returned a string in the past. self::iconv() might return false, which you don't check. This might lead to a bug?

I 'm also concerned about that, after test fail.

So I closed this PR