ezyang / htmlpurifier

Standards compliant HTML filter written in PHP
http://htmlpurifier.org
GNU Lesser General Public License v2.1
3.03k stars 323 forks source link

Add PHP 8.2 to CI #335

Closed TimWolla closed 1 year ago

TimWolla commented 1 year ago

see ezyang/htmlpurifier#334

ezyang commented 1 year ago

but it fails 👀

TimWolla commented 1 year ago

Indeed it does, I trusted #334 and wanted to get the CI in before the release. Maybe someone (@bytestream?) can pick up the last three issues. I won't have time for that on short notice.

bytestream commented 1 year ago

@TimWolla https://github.com/ezyang/htmlpurifier/pull/337 :man_shrugging:

PR description should also say Closes #334 rather than see

TimWolla commented 1 year ago

man_shrugging

Thanks for tackling this!

PR description should also say

No, because this PR does not actually perform the release as requested in the issue.