[refactor] Use range() function instead of string increment

ezyang / htmlpurifier

Standards compliant HTML filter written in PHP

http://htmlpurifier.org

GNU Lesser General Public License v2.1

3.02k stars 323 forks source link

[refactor] Use range() function instead of string increment #367

Closed Girgias closed 1 year ago

Girgias commented 1 year ago

This was found during the analysis for https://wiki.php.net/rfc/saner-inc-dec-operators

~~I don't know what is the minimal version targeted, so the line which defines $c may need to be changes to use array_merge()~~ CI is telling me it's PHP-5.6 so that's clear.

vlakoff commented 8 months ago

At the end, we could more simply do $this->mask = '_- ' . implode($c);

pyres01 commented 8 months ago

邮件已收到，谢谢！

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 4.17.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: