Closed apaszke closed 7 years ago
For the immediate PR, we need a test for SavedVariables tracing fix. We should also bump up the priority of the autograd/nn-like testing framework for tracing and running (but I wouldn't block the PR on this).
Thanks. Tests need to pass before going in.
save_for_backward
would break tracing (outputs wouldn't have the trace associated with them)word_lanuage_model
we're still missing support forIndex
ing with slices (we should probably have our PyTorch custom index op) andSubConstant
that I'm working on. I didn't manage to push it yet, because it needs to be implemented as Neg + AddConstant, but the code breaks with an assertion failure in the graph fuser if I don't set the type for Neg. I'll add support for manipulating types from Python and send a fix for this later.