Prune null edges in Eval nodes

ezyang / pytorch-unattached

Tensors and Dynamic neural networks in Python with strong GPU acceleration

http://pytorch.org

Other

20 stars 8 forks source link

Prune null edges in Eval nodes #233

Closed apaszke closed 7 years ago

apaszke commented 7 years ago

Recent autograd refactor has destabilized the tracer, because it has to handle NULL edges in the graph now (it reverted some of my previous changes). This should fix it (word_language_model seems to run just fine)

ezyang commented 7 years ago

LGTM. I added some comments, in my usual style. I'll revive patches from my other PR which we should also keep.

ezyang commented 7 years ago

(CI looks failed because we canceled it on the comment commits.)

zdevito commented 7 years ago

LGTM.