refactor: Modify the return type for `Passkey.register` to `PasskeyRegistrationResult` and update types following the w3c specification

f-23 / react-native-passkey

Passkeys for React Native

MIT License

121 stars 25 forks source link

refactor: Modify the return type for `Passkey.register` to `PasskeyRegistrationResult` and update types following the w3c specification #15

Closed fabriziofff closed 9 months ago

fabriziofff commented 10 months ago

This PR changes the return type of Passkey.register from Promise<object>to Promise<PasskeyRegistrationResult> in order to get a typed object when invoked.

Additionally, in order to comply with the w3c passkey level 2 specification, this PR also suggests making minor changes to the types PasskeyRegistrationRequest and PasskeyAuthenticationRequest.

Bonus: Minor typo in the ios/Passkey.swift 😛

f-23 commented 9 months ago

Looks good, thank you for the PR!