f-23 / react-native-passkey

Passkeys for React Native
MIT License
121 stars 25 forks source link

Updating to latest androix.credentials library #38

Closed Jodee90 closed 4 days ago

Jodee90 commented 1 month ago

As experienced in some Android 14 devices, there was an error thrown androidx.credentials.exceptions.CreateCredentialUnsupportedException: Your device doesn't support credential manager upon credentials registration request, making the registration fail.

Digging up in the Google documentation, I found out that a fallback was introduced in version 1.2.1.

Provided fallback solution when platform credential manager is not available. ([b/310701473](https://b.corp.google.com/issues/310701473))

Google Release Notes

Upgrading the library to the latest stable release of androidx.credentials library (1.2.2) fixed the issue.

sirkostya009 commented 1 week ago

You probably shouldn't bump version to a beta and improve error logging in a pull request that only mentions the former. I would suggest reverting commit https://github.com/f-23/react-native-passkey/pull/38/commits/f5d9142575e0c1a02a0bab6290648976ec605dd3. However, @f-23 could you please look into this? Both the version bump and improved error logging would benefit this library greatly.

Jodee90 commented 1 week ago

You probably shouldn't bump version to a beta and improve error logging in a pull request that only mentions the former. I would suggest reverting commit f5d9142. However, @f-23 could you please look into this? Both the version bump and improved error logging would benefit this library greatly.

Damn, I mistakenly commited to the same branch. I also bumped to 1.3.0-beta02 which enables the prf extension for android versions older than 13. I can always revert the commit if that doesn't sound ok.

PS: 1.3.0-beta02 has been tested on several devices (android 11 to 15) from my site

f-23 commented 4 days ago

Thank you for the PR!

I will merge this for the next release for broader prf extension support. I have tested this beta version myself and it looks good so far. I think it's fair to include it at this point and update it to the 1.3.0 release version later on.