AdaptiveAvgPool3d: wait for bug resolved -> delete warning

f-dangel / backpack

BackPACK - a backpropagation package built on top of PyTorch which efficiently computes quantities other than the gradient.

https://backpack.pt/

MIT License

561 stars 55 forks source link

Open schaefertim opened 3 years ago

schaefertim commented 3 years ago

As soon as https://github.com/pytorch/pytorch/issues/60524 is resolved, we can delete our warnings:

backpack/core/derivatives/adaptive_avg_pool_nd.py: delete warning in check_parameters
test/core/derivatives/derivatives_test.py: delete test of warning in test_ea_jac_t_mat_jac_prod and test_jac_t_mat_prod

f-dangel commented 3 years ago

The bug still persists in torch==1.9.1. @schaefertim could you update the skip condition in the tests?

f-dangel commented 3 years ago

Fixed in torch=1.10.0 (#60630).