search

f-dangel / backpack

BackPACK - a backpropagation package built on top of PyTorch which efficiently computes quantities other than the gradient.
https://backpack.pt/
MIT License
555 stars 55 forks source link

[ADD/TEST] K-FAC for linear layer ResNets #237

Closed jabader97 closed 2 years ago

jabader97 commented 2 years ago

Issue I was describing in the meeting was just because I was confused on the SumModule extension--doing it as the example worked well. Still got an error with the identity, but it was a very nice error message.

Also I branched for this from the last issue in an attempt to avoid some merging later, but now this pull request includes changes from both issues. I can branch from the main one next time (assuming it's cleaner to have the issues separate).

f-dangel commented 2 years ago

Thanks! I will review after the current merge conflict has been resolved.

f-dangel commented 2 years ago

GitHub still shows that there's a merge conflict. Could you resolve that?

f-dangel commented 2 years ago

Resolves https://github.com/fKunstner/backpack-discuss/issues/120