f-dangel / curvlinops

PyTorch linear operators for curvature matrices (Hessian, Fisher/GGN, KFAC, ...)
https://curvlinops.readthedocs.io/en/latest/
MIT License
18 stars 8 forks source link

[BUG] Wrong dtype for random vectors used in KFAC's deterministic checks #133

Closed f-dangel closed 1 month ago

f-dangel commented 2 months ago

Resolves #132.

The problem was that the deterministic checks generate random numpy vectors which were then converted to the incorrect PyTorch data dtype.

Interestingly, I found that the other linear operators, such as Hessian, GGN, Fisher, EF, were not affected by this problem. I'm not 100% sure why. @runame any thoughts?

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 11409577418

Details


Files with Coverage Reduction New Missed Lines %
curvlinops/examples/utils.py 10 31.25%
curvlinops/fisher.py 46 26.47%
<!-- Total: 56 -->
Totals Coverage Status
Change from base Build 11001385384: -3.7%
Covered Lines: 1349
Relevant Lines: 1519

💛 - Coveralls