Closed runame closed 6 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
curvlinops/inverse.py | 16 | 17 | 94.12% | ||
curvlinops/kfac.py | 36 | 41 | 87.8% | ||
<!-- | Total: | 52 | 58 | 89.66% | --> |
Totals | |
---|---|
Change from base Build 8250604944: | 0.2% |
Covered Lines: | 1017 |
Relevant Lines: | 1138 |
Addresses #71, but only for the
KFACLinearOperator
andKFACInverseLinearOperator
.KFACLinearOperator
/KFACInverseLinearOperator
is arguably the only linear operator here that is likely to be used for preconditioned-gradient methods for large scale neural networks. Therefore, addingtorch_matmat
andtorch_matvec
methods seem like a simple solution to avoid unnecessary device transfers, which are a bottleneck for this use case. However, this doesn't address the issue in general.